This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Make PE images deterministic by default.
- From: nick clifton <nickc at redhat dot com>
- To: Cory Fields <cory at coryfields dot com>, binutils at sourceware dot org
- Date: Thu, 21 Nov 2013 09:53:02 +0000
- Subject: Re: [PATCH] Make PE images deterministic by default.
- Authentication-results: sourceware.org; auth=none
- References: <1384978791-13189-1-git-send-email-cory at coryfields dot com>
Hi Cory,
binutils/Changelog
2013-11-20 Cory Fields <cory@coryfields.com>
* bfd/libcoff-in.h: Add insert_timestamp flag to the pe_data struct.
* bfd/libcoff.h: Update after change to bfd/libcoff-in.h.
* bfd/peXXigen.c (_bfd_XXi_only_swap_filehdr_out): Only use a real
timestamp if --insert-timestamp was used.
* ld/pe-dll.c (fill_edata): Likewise.
* ld/emultempl/pe.em: Add the --insert-timestamp option.
* ld/emultempl/pep.em: Likewise for 64bit.
* ld/ld.texinfo: Document the --insert-timestamp option.
Approved, but with one small caveat:
+ // Only use a real timestamp if the option was chosen
Could we have a C-style comment here please ?
Cheers
Nick