This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Commit: AArch64: Do not complain about invalid pstate values
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>, Yufeng Zhang <Yufeng dot Zhang at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 19 Nov 2013 18:05:04 +0000
- Subject: Re: Commit: AArch64: Do not complain about invalid pstate values
- Authentication-results: sourceware.org; auth=none
- References: <87k3g4z3si dot fsf at redhat dot com>
On 19 November 2013 17:42, Nick Clifton <nickc@redhat.com> wrote:
> Hi Guys,
>
> I have checked in the patch below to fix a small problem with the
> AArch64 assembler - it was issuing error messages for deprecated
> system register names when parsing a PSTATE value.
>
> Cheers
> Nick
>
> gas/ChangeLog
> 2013-11-19 Nick Clifton <nickc@redhat.com>
>
> * config/tc-aarch64.c (parse_sys_reg): Do not issue error messages
> for deprecated system registers when parsing pstate fields.
>
> diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
> index fb0ae33..7d50381 100644
> --- a/gas/config/tc-aarch64.c
> +++ b/gas/config/tc-aarch64.c
> @@ -3314,7 +3314,10 @@ parse_sys_reg (char **str, struct hash_control *sys_regs, int imple_defined_p)
> }
> else
> {
> - if (aarch64_sys_reg_deprecated_p (o))
> + /* Only check system register names for deprecation. If we have
> + been given a PSTATE field name (impled_defined_p == 0) then allow
> + any value. */
> + if (imple_defined_p && aarch64_sys_reg_deprecated_p (o))
> as_warn (_("system register name '%s' is deprecated and may be "
> "removed in a future release"), buf);
> value = o->value;
I think the real issue here is that the pstate sysreg table doesn;t
have a flags column in it.
Yufeng?
/Marcus