This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] Fix version.dll test failure
- From: Tristan Gingold <gingold at adacore dot com>
- To: "binutils at sourceware dot org Development" <binutils at sourceware dot org>
- Date: Tue, 19 Nov 2013 14:52:00 +0100
- Subject: [PATCH] Fix version.dll test failure
- Authentication-results: sourceware.org; auth=none
Hi,
when cross-testing binutils for x86_64-mingw32, the test version.dll test of dlltool.exp fails because dlltool needs to invoke the assembler. There are the $dlltool_gas_flag flags to specify which assembler to run, but it wasn't on the command line.
Ok for trunk ?
Tristan.
binutils/testsuite
2013-11-19 Tristan Gingold <gingold@adacore.com>
* binutils-all/dlltool.exp: Add dlltool_gas_flag to version.dll test.
diff --git a/binutils/testsuite/binutils-all/dlltool.exp b/binutils/testsuite/binutils-all/dlltool.exp
index 1409d3c..e0385d7 100644
--- a/binutils/testsuite/binutils-all/dlltool.exp
+++ b/binutils/testsuite/binutils-all/dlltool.exp
@@ -53,8 +53,8 @@ if { "$target_xfail" == "yes" } {
setup_xfail *-*
}
-verbose "$DLLTOOL -l libversion.a --def $srcdir/$subdir/version.def" 1
-catch "exec $DLLTOOL -l libersion.a --def $srcdir/$subdir/version.def" err
+verbose "$DLLTOOL -l libversion.a --def $srcdir/$subdir/version.def $dlltool_gas_flag" 1
+catch "exec $DLLTOOL -l libersion.a --def $srcdir/$subdir/version.def $dlltool_gas_flag" err
if ![string match "" $err] then {
send_log "$err\n"