This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold testsuite: conditionalize -fmerge-constants use, clean up test
- From: Cary Coutant <ccoutant at google dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 31 Oct 2013 11:40:01 -0700
- Subject: Re: [PATCH] gold testsuite: conditionalize -fmerge-constants use, clean up test
- Authentication-results: sourceware.org; auth=none
- References: <CAB=4xhrR=8zfSLG7jWBKkeyuLB5bGxCoVsbbTpgnveZycoop4A at mail dot gmail dot com> <CAHACq4pmj=LA0kmaxM=FibEM3hcmzFND6GSAMUi4pU1zpYv8Yg at mail dot gmail dot com> <CAB=4xhohaOzBv7Tik1QDD7oYZMV=M5Qma2vQMDNVuL1OGgc+OQ at mail dot gmail dot com>
>> You've got two different spellings here: MERGE_CONSTANTS_FLAGS and
>> MERGE_CONSTANTS_CFLAGS. How about just "MERGE_CONSTANTS_FLAG"?
>
> Oops. The former was a typo, I was going for consistency with other
> *_CFLAGS variables. But _FLAG is fine by me.
>
>> OK with that change.
>
> Done and committed.
Sorry, I missed another case where you had two different spellings.
I've committed the following patch.
-cary
2013-10-31 Cary Coutant <ccoutant@google.com>
* gold/configure.ac: Fix check for -fmerge-constants.
* gold/configure.ac: Regenerate.
diff --git a/gold/configure.ac b/gold/configure.ac
index c23117b..82ad11e 100644
--- a/gold/configure.ac
+++ b/gold/configure.ac
@@ -343,8 +343,8 @@ AC_CACHE_CHECK([whether $CC supports -fmerge-constants],
save_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS -fmerge-constants"
AC_COMPILE_IFELSE([const char *s = "foo";],
- [have_merge_constants=yes],
- [have_merge_constants=no])
+ [gold_cv_merge_constants=yes],
+ [gold_cv_merge_constants=no])
CFLAGS="$save_CFLAGS"])
AC_SUBST([MERGE_CONSTANTS_FLAG])
AS_IF([test "$gold_cv_merge_constants" = yes],