This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Reorder MSA branches
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Chao-Ying Fu <Chao-Ying dot Fu at imgtec dot com>
- Cc: "'Maciej W. Rozycki'" <macro at codesourcery dot com>, "'binutils\ at sourceware dot org'" <binutils at sourceware dot org>
- Date: Fri, 18 Oct 2013 09:04:52 +0100
- Subject: Re: [PATCH] Reorder MSA branches
- Authentication-results: sourceware.org; auth=none
- References: <81D57523CB07B24881D63DE650C6ED824C35B3F9 at BADAG01 dot ba dot imgtec dot org>
Chao-Ying Fu <Chao-Ying.Fu@imgtec.com> writes:
> Version 2.
> Because the MSA registers share the FP registers (if the FPU is present),
> we combine FP and MSA register dependences together.
I think we should go for this one. The patch looks good with the testcase
added to the testsuite.
One very minor formatting nit though:
> @@ -4161,7 +4161,8 @@ fpr_read_mask (const struct mips_cl_insn
> unsigned long pinfo;
> unsigned int mask;
>
> - mask = insn_reg_mask (ip, (1 << OP_REG_FP) | (1 << OP_REG_VEC),
> + mask = insn_reg_mask (ip, (1 << OP_REG_FP) | (1 << OP_REG_VEC)
> + | (1 << OP_REG_MSA),
> insn_read_mask (ip->insn_mo));
> pinfo = ip->insn_mo->pinfo;
> /* Conservatively treat all operands to an FP_D instruction are doubles.
> @@ -4179,7 +4180,8 @@ fpr_write_mask (const struct mips_cl_ins
> unsigned long pinfo;
> unsigned int mask;
>
> - mask = insn_reg_mask (ip, (1 << OP_REG_FP) | (1 << OP_REG_VEC),
> + mask = insn_reg_mask (ip, (1 << OP_REG_FP) | (1 << OP_REG_VEC)
> + | (1 << OP_REG_MSA),
> insn_write_mask (ip->insn_mo));
> pinfo = ip->insn_mo->pinfo;
> /* Conservatively treat all operands to an FP_D instruction are doubles.
In these two cases, please add an extra "(" (the GCC emacs indentation rule).
mask = insn_reg_mask (ip, ((1 << OP_REG_FP) | (1 << OP_REG_VEC)
| (1 << OP_REG_MSA)),
Thanks,
Richard