This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold testsuite: conditionalize -fmerge-constants use, clean up test
- From: Cary Coutant <ccoutant at google dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 11 Oct 2013 14:45:43 -0700
- Subject: Re: [PATCH] gold testsuite: conditionalize -fmerge-constants use, clean up test
- Authentication-results: sourceware.org; auth=none
- References: <CAB=4xhrR=8zfSLG7jWBKkeyuLB5bGxCoVsbbTpgnveZycoop4A at mail dot gmail dot com>
> gold/
> * configure.ac (MERGE_CONSTANTS_CFLAGS): New check.
> * configure: Regenerate.
> * Makefile.in: Regenerate.
> * testsuite/merge_string_literals_1.c: Renamed to have .cc suffix.
> * testsuite/merge_string_literals_2.c: Likewise.
> * testsuite/Makefile.am
> (merge_string_literals_1.o, merge_string_literals_2.o): Update deps.
> (AM_CFLAGS, AM_CXXFLAGS): Use $(MERGE_CONSTANTS_FLAGS) in place of
> literal -fmerge-constants.
> * testsuite/Makefile.in: Regenerate.
You've got two different spellings here: MERGE_CONSTANTS_FLAGS and
MERGE_CONSTANTS_CFLAGS. How about just "MERGE_CONSTANTS_FLAG"?
OK with that change.
-cary