This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Mips target in gold - part 3
- From: Cary Coutant <ccoutant at google dot com>
- To: Sasa Stankovic <Sasa dot Stankovic at imgtec dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, "iant at google dot com" <iant at google dot com>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Tue, 30 Jul 2013 14:42:31 -0700
- Subject: Re: Mips target in gold - part 3
- References: <7EDC79CE48A9944A88968ABABE6038EE22803419 at BADAG02 dot ba dot imgtec dot org>
> 3. nonvis.patch
> This patch adds a method in the class Symbol that sets the non-visibility part of the st_other field. Mips uses st_other's non-visibility part to record different flags about the symbol (whether it has plt stub, whether it is mips16 etc.)
Needs a ChangeLog entry.
--- a/gold/symtab.h
+++ b/gold/symtab.h
@@ -259,6 +259,11 @@ class Symbol
nonvis() const
{ return this->nonvis_; }
+ // Set the non-visibility part of the st_other field.
+ void
+ set_nonvis(unsigned int nonvis)
+ { this->nonvis_ = nonvis; }
I believe that this should be a protected member -- you only use it
from a class derived from Symbol, right? I don't think there's any
reason to expose this interface publicly.
-cary