This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR gas/15220: MIPS/Loongson 2F: Wrong opcodes for madd.ps/msub.ps/nmadd.ps/nmsub.ps
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Aaro Koskinen <aaro dot koskinen at iki dot fi>
- Cc: binutils at sourceware dot org
- Date: Thu, 25 Jul 2013 20:11:45 +0100
- Subject: Re: [PATCH] PR gas/15220: MIPS/Loongson 2F: Wrong opcodes for madd.ps/msub.ps/nmadd.ps/nmsub.ps
- References: <20130721161658 dot GA29618 at blackmetal dot musicnaut dot iki dot fi>
Aaro Koskinen <aaro.koskinen@iki.fi> writes:
> PR gas/15220
> * mips-opc.c (mips_builtin_opcodes): Fix wrong opcodes for
> Loongson 2F madd.ps, msub.ps, nmadd.ps and nmsub.ps.
Applied, thanks. I also needed the testsuite patch below.
Richard
gas/testsuite/
* gas/mips/loongson-2f.d: Fix expected output for madd.ps,
msub.ps, nmadd.ps and nmsub.ps.
Index: gas/testsuite/gas/mips/loongson-2f.d
===================================================================
--- gas/testsuite/gas/mips/loongson-2f.d 2013-06-26 08:04:10.229006905 +0100
+++ gas/testsuite/gas/mips/loongson-2f.d 2013-07-25 20:05:03.906007652 +0100
@@ -28,16 +28,16 @@ Disassembly of section .text:
[0-9a-f]+ <fpu_insns>:
.*: 72020818 madd.s \$f0,\$f1,\$f2
.*: 722520d8 madd.d \$f3,\$f4,\$f5
-.*: 71683998 madd.ps \$f6,\$f7,\$f8
+.*: 72c83998 madd.ps \$f6,\$f7,\$f8
.*: 720b5259 msub.s \$f9,\$f10,\$f11
.*: 722e6b19 msub.d \$f12,\$f13,\$f14
-.*: 717183d9 msub.ps \$f15,\$f16,\$f17
+.*: 72d183d9 msub.ps \$f15,\$f16,\$f17
.*: 72149c9a nmadd.s \$f18,\$f19,\$f20
.*: 7237b55a nmadd.d \$f21,\$f22,\$f23
-.*: 717ace1a nmadd.ps \$f24,\$f25,\$f26
+.*: 72dace1a nmadd.ps \$f24,\$f25,\$f26
.*: 721de6db nmsub.s \$f27,\$f28,\$f29
.*: 7222081b nmsub.d \$f0,\$f1,\$f2
-.*: 716520db nmsub.ps \$f3,\$f4,\$f5
+.*: 72c520db nmsub.ps \$f3,\$f4,\$f5
[0-9a-f]+ <simd_insns>:
.*: 4b420802 packsshb \$f0,\$f1,\$f2