This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: -Trodata-segment and fix -Ttext-segment for isolate_execinstr targets
- From: Cary Coutant <ccoutant at google dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 19 Jul 2013 15:58:51 -0700
- Subject: Re: [PATCH] gold: -Trodata-segment and fix -Ttext-segment for isolate_execinstr targets
- References: <CAB=4xhqz_=P7epMD938btyKBBksGAtRdczD4zG7CX7sWox5LdA at mail dot gmail dot com> <CAHACq4oHqwZK+3N333UMc_zyaUiBFbuSkNeMi9hmNfXMzGukXQ at mail dot gmail dot com> <CAB=4xhphZZejOHdz0O9hRTjPfr=BuZiyp7_3J0tOnzyCDsSA6w at mail dot gmail dot com>
> gold/
> 2013-07-19 Roland McGrath <mcgrathr@google.com>
>
> * options.h (General_options): Add -Trodata-segment option.
> * parameters.cc (Parameters::check_rodata_segment): New function.
> (Parameters::set_target_once): Call it.
> * parameters.h (Parameters): Declare it (private member function).
> * layout.cc (load_seg_unusable_for_headers): New function, broken
> out of Layout::relaxation_loop_body. If TARGET->isolate_execinstr()
> then validate rodata segment rather than text segment.
> (relaxation_loop_body): Call that.
> (is_text_segment): New function. Don't admit a non-executable
> segment if TARGET->isolate_execinstr().
> (set_segment_offsets): Call it. Honor -Trodata-segment option.
This is OK. Thanks!
-cary