This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS: Define descriptive names for GNU attribute values
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: <binutils at sourceware dot org>, <gdb-patches at sourceware dot org>
- Date: Mon, 15 Jul 2013 16:54:51 +0100
- Subject: Re: [PATCH] MIPS: Define descriptive names for GNU attribute values
- References: <alpine dot DEB dot 1 dot 10 dot 1307121705400 dot 20590 at tp dot orcam dot me dot uk> <8761we3owq dot fsf at talisman dot default>
On Sat, 13 Jul 2013, Richard Sandiford wrote:
> > include/elf/
> > * mips.h (Tag_GNU_MIPS_ABI_FP): Remove comment.
> > (Val_GNU_MIPS_ABI_FP_ANY, Val_GNU_MIPS_ABI_FP_DOUBLE,
> > Val_GNU_MIPS_ABI_FP_SINGLE, Val_GNU_MIPS_ABI_FP_SOFT,
> > Val_GNU_MIPS_ABI_FP_64): New enum.
> >
> > bfd/
> > * elfxx-mips.c (mips_elf_merge_obj_attributes): Replace hardcoded
> > magic numbers with enum values.
> >
> > binutils/
> > * readelf.c (display_mips_gnu_attribute): Replace hardcoded magic
> > numbers with enum values.
> >
> > gdb/
> > * mips-tdep.c (mips_gdbarch_init): Replace hardcoded magic
> > numbers with enum values.
>
> OK. Nice cleanup, thanks.
Committed now, thanks.
Maciej