This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] MIPS EVA ASE Support



> -----Original Message-----
> From: Maciej W. Rozycki [mailto:macro@codesourcery.com]
> Sent: Monday, June 17, 2013 7:13 PM
> To: Moore, Catherine
> Cc: Richard Sandiford; binutils@sourceware.org
> Subject: RE: [PATCH] MIPS EVA ASE Support
> 
> On Mon, 17 Jun 2013, Moore, Catherine wrote:
> 
> > > > RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips.exp,v
> > > > retrieving revision 1.222
> > > > diff -p -u -r1.222 mips.exp
> > > > --- gas/testsuite/gas/mips/mips.exp	14 Jun 2013 13:30:28 -0000
> 	1.222
> > > > +++ gas/testsuite/gas/mips/mips.exp	17 Jun 2013 20:28:48 -0000
> > > > @@ -849,6 +849,8 @@ if { [istarget mips*-*-vxworks*] } {
> > > >  					[mips_arch_list_matching mips64r2 \
> > > >  					    !micromips]
> > > >
> > > > +    run_dump_test_arches "eva"		[mips_arch_list_matching
> > > mips32r2 !octeon]
> > >
> > > For the record, this is going to fail on ecoff, as Maciej pointed
> > > out for one of the other recent patches.  I'm planning to
> > > significantly trim the amount of testing we do on ecoff though --
> > > hopefully within the week -- so let's commit this as-is.
> > >
> > > OK with those changes (or non-change in the last case), thanks.
> 
>  I suspect it might make sense to commit the INSN_ASE_MASK macro
> removal, which is functionally unrelated, as a separate change.  Otherwise it'll
> get lost in the mass of EVA-specific changes.  I won't insist on that if Richard
> disagrees though.  The change looks otherwise fine to me.
> 

Hi Maciej,
I committed the entire patch before reading your suggestion.  Sorry!
Catherine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]