This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS EVA ASE Support
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: "Moore\, Catherine" <Catherine_Moore at mentor dot com>, "binutils\ at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 12 Jun 2013 19:38:10 +0100
- Subject: Re: [PATCH] MIPS EVA ASE Support
- References: <FD3DCEAC5B03E9408544A1E416F11242F8FC6EE7 at NA-MBX-01 dot mgc dot mentorg dot com> <87fvwz9hsg dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FC9639 at NA-MBX-01 dot mgc dot mentorg dot com> <87bo7g99yn dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FC9A3B at NA-MBX-01 dot mgc dot mentorg dot com> <87ip1l7oz9 dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FCA5F6 at NA-MBX-01 dot mgc dot mentorg dot com> <alpine dot DEB dot 1 dot 10 dot 1306121710190 dot 16287 at tp dot orcam dot me dot uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
>> {
>> - /* A 12-bit or 0-bit offset field is too narrow to be used
>> - for a low-part relocation, so load the whole address into
>> - the auxillary register. In the case of "A(b)" addresses,
>> + /* A 12-bit, 0-bit or 9-bit offset field is too narrow to be
>
> Suggest sorting the bit count, i.e.:
>
> /* A 12-bit, 9-bit or 0-bit offset field is too narrow to be
Bikeshed stuff, but I'd prefer "The offset field is too narrow..."
and drop the list altogether.
> I'll let Richard comment on the rest.
My only other comment is: rather than
if (mips_opts.micromips)
offbits = 12;
please use:
offbits = (mips_opts.micromips ? 12 : 16);
(several instances).
Thanks,
Richard