This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Aw: Re: [PATCH] Support VU0 on MIPS R5900
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: JÃrgen Urban <JuergenUrban at gmx dot de>
- Cc: binutils at sourceware dot org
- Date: Mon, 20 May 2013 23:00:16 +0100
- Subject: Re: Aw: Re: [PATCH] Support VU0 on MIPS R5900
- References: <20130108234130 dot 27410 at gmx dot net> <87a9rrso6l dot fsf at talisman dot default> <trinity-357f2c0f-746d-43de-b9dc-6053dff9d1f2-1369080004599 at 3capp-gmx-bs18>
Hi JÃrgen,
Thanks for the patch. The code itself looks good. However, I think it'd
be better to extend the test to include the four branch instructions.
It should also cover the LQC2 and SQC2 macros added here:
> @@ -8201,6 +8201,13 @@ macro (struct mips_cl_insn *ip)
> /* Itbl support may require additional care here. */
> coproc = 1;
> goto ld_st;
> + case M_LQC2_AB:
> + ab = 1;
> + s = "lqc2";
> + fmt = "E,o(b)";
> + /* Itbl support may require additional care here. */
> + coproc = 1;
> + goto ld_st;
> case M_LDC3_AB:
> ab = 1;
> s = "ldc3";
> @@ -8390,6 +8397,13 @@ macro (struct mips_cl_insn *ip)
> /* Itbl support may require additional care here. */
> coproc = 1;
> goto ld_st;
> + case M_SQC2_AB:
> + ab = 1;
> + s = "sqc2";
> + fmt = "E,o(b)";
> + /* Itbl support may require additional care here. */
> + coproc = 1;
> + goto ld_st;
> case M_SDC3_AB:
> ab = 1;
> gas_assert (!mips_opts.micromips);
E.g. it could check that things like:
lqc2 $8, 0x8000($10)
get decomposed into the $1-based sequence.
Thanks,
Richard