This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD] add new method for computing a build ID (take 2)
- From: Cary Coutant <ccoutant at google dot com>
- To: Geoff Pike <gpike at chromium dot org>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Fri, 26 Apr 2013 14:40:49 -0700
- Subject: Re: [GOLD] add new method for computing a build ID (take 2)
- References: <20121030234648 dot A481F1E093B at geoffp dot mtv dot corp dot google dot com> <CAHACq4qzxAktPsuszQZDYS_RWV623QLNm3gtD0+cXzX-b8tuig at mail dot gmail dot com> <CADBJY1gwH7h2+dkszfy00eGcfSLrrSppCHG_eLDg8M90vssiOw at mail dot gmail dot com> <CAHACq4oPX+8yoWsMam6zG0f6vO3o0kKWzJ+Q4+gyj6eNzwX1vg at mail dot gmail dot com> <CADBJY1iXT0FdAca=3EoJhzYXQf=a_WsvFy5ONF3YK0ZQDKBkNg at mail dot gmail dot com> <CAHACq4oPbeo=zC2-nx8sybnnR0p1wh+NaMko+wTSz-xRaXMh-g at mail dot gmail dot com> <CADBJY1gqVwPcHYaKYhHwCmF0wg5TfrvCkNwT2=q7Jw51y8D=0w at mail dot gmail dot com>
> * gold.cc (queue_final_tasks): invoke layout->queue_build_id_tasks().
> * layout.cc (Hash_task): New class.
> (Layout::queue_build_id_tasks): New function.
> (Layout::write_build_id): Handle single-thread portion of build ID
> computation. (In some cases, all of it is single-threaded.) Replace
> {sha1,md5}_process_bytes with {sha1,md5}_buffer to get the same
> functionality in fewer lines of code.
> * layout.h (Layout::queue_build_id_tasks): New function declaration.
> * options.h (General_options): make "--build-id" default to tree
> rather than sha1. Add two new options related to --build-id=tree:
> --build-id-chunk-size-for-treehash and
> --build-id-min-file-size-for-treehash.
> * Makefile.am: add testing of --build-id=tree and related new options
> (these tests will be invoked by "make check").
> * Makefile.in: Regenerate.
I've committed this patch on Geoff's behalf. Thanks, Geoff!
-cary