This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[gold patch] Fix problem with scripts and relocatable links

From: Cary Coutant <ccoutant at google dot com>
To: Ian Lance Taylor <iant at google dot com>, Binutils <binutils at sourceware dot org>
Date: Fri, 12 Apr 2013 15:53:47 -0700
Subject: [gold patch] Fix problem with scripts and relocatable links

When a script file in a relocatable link defines a symbol in a
section, gold does not output the symbol's correct value if the
section's starting address is not 0. This patch fixes the problem by
subtracting the output section's starting address when writing a
section-relative symbol.

Tested on x86_64. OK to commit?

-cary

gold/
    * symtab.cc (Symbol_table::sized_write_globals): Subtract
    section starting address for relocatable link.
    * testsuite/Makefile.am (script_test_11): New test.
    * testsuite/Makefile.in: Regenerate.
    * testsuite/script_test_11.c: New source file.
    * testsuite/script_test_11.t: New linker script.

Attachment: gold-dot-dashr-patch-1.txt
Description: Text document

Follow-Ups:
- Re: [gold patch] Fix problem with scripts and relocatable links
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]