This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, MIPS, OPCODE] mips-dis.c build error

From: "Maciej W. Rozycki" <macro at codesourcery dot com>
To: Michael Eager <eager at eagerm dot com>
Cc: Richard Sandiford <rdsandiford at googlemail dot com>, Binutils <binutils at sourceware dot org>
Date: Sat, 9 Mar 2013 00:25:25 +0000
Subject: Re: [PATCH, MIPS, OPCODE] mips-dis.c build error
References: <513A2FCB.5020200@eagerm.com> <alpine.DEB.1.10.1303081916350.21335@tp.orcam.me.uk> <513A4615.9040808@eagerm.com>

On Fri, 8 Mar 2013, Michael Eager wrote:

> >   Nothing wrong with your change, but perhaps we should fix the cause
> > instead?
> 
> There are many places in the file where a signed int is used hold a
> insn or some piece of one, like the opcode.  Fixing all of the places
> where int should be replaced by unsigned, replacing all of the %d's in
> formats with %u, and changing function declarations, would amount to
> several dozens of modified lines.   I opted for a one line change.

 Sure.  No doubt however that Richard will be more than happy to fix them.

  Maciej

References:
- [PATCH, MIPS, OPCODE] mips-dis.c build error
  - From: Michael Eager
- Re: [PATCH, MIPS, OPCODE] mips-dis.c build error
  - From: Maciej W. Rozycki
- Re: [PATCH, MIPS, OPCODE] mips-dis.c build error
  - From: Michael Eager

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]