This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] MIPS/BFD: Clarify _PROCEDURE_LINKAGE_TABLE_ handling
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: <binutils at sourceware dot org>
- Date: Mon, 18 Feb 2013 14:23:52 +0000
- Subject: [PATCH] MIPS/BFD: Clarify _PROCEDURE_LINKAGE_TABLE_ handling
Hi,
We don't let _bfd_elf_create_dynamic_sections create
_PROCEDURE_LINKAGE_TABLE_ except on VxWorks targets, because for other
targets we don't know that early yet if we'll be using a PLT or lazy
binding stubs (the place we create that symbol on other targets is
_bfd_mips_elf_size_dynamic_sections). The change below adjusts a comment
we have in _bfd_mips_elf_create_dynamic_sections to be clear on that; and
-- while at it -- corrects a typo in the _PROCEDURE_LINKAGE_TABLE_
reference there.
This is almost obviously correct, but just in case -- OK to apply?
2013-02-18 Maciej W. Rozycki <macro@codesourcery.com>
bfd/
* elfxx-mips.c (_bfd_mips_elf_create_dynamic_sections): Clarify
comment on _PROCEDURE_LINKAGE_TABLE_ creation.
Maciej
binutils-bfd-vxworks-pltsym.diff
Index: binutils-fsf-trunk-quilt/bfd/elfxx-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/elfxx-mips.c 2013-02-17 03:31:35.774076878 +0000
+++ binutils-fsf-trunk-quilt/bfd/elfxx-mips.c 2013-02-17 07:06:45.705501283 +0000
@@ -7308,7 +7308,7 @@ _bfd_mips_elf_create_dynamic_sections (b
}
/* Create the .plt, .rel(a).plt, .dynbss and .rel(a).bss sections.
- Also create the _PROCEDURE_LINKAGE_TABLE symbol. */
+ Also, on VxWorks, create the _PROCEDURE_LINKAGE_TABLE_ symbol. */
if (!_bfd_elf_create_dynamic_sections (abfd, info))
return FALSE;