This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2 v4] ld: change --enable-new-dtags to only generate new dtags


On Thursday 17 January 2013 16:33:05 Alan Modra wrote:
> On Thu, Jan 17, 2013 at 02:22:20PM -0500, Mike Frysinger wrote:
> > --- a/bfd/elflink.c
> > +++ b/bfd/elflink.c
> > 
> > -	  if  (info->new_dtags)
> > +	  if (!info->new_dtags)
> > +	    {
> > +	      if (!_bfd_elf_add_dynamic_entry (info, DT_RPATH, indx))
> > +		return FALSE;
> > +	    }
> > +	  else
> >  	    {
> >  	      _bfd_elf_strtab_addref (elf_hash_table (info)->dynstr, indx);
> >  	      if (!_bfd_elf_add_dynamic_entry (info, DT_RUNPATH, indx))
> 
> That _bfd_elf_strtab_addref will cause assertion failures when you get
> around to testing this patch, I think.

err i fixed that locally.  i must have uploaded the wrong version :/.

i did verify `make check` still worked ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]