Re: PATCH: PR gas/14899: Missing gas dependency for ld and gold

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Nov 30, 2012 at 5:59 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Nov 30, 2012 at 3:23 PM, Ian Lance Taylor <iant@google.com> wrote:
>> On Fri, Nov 30, 2012 at 11:19 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>
>>> 2012-11-30  H.J. Lu  <hongjiu.lu@intel.com>
>>>
>>>         PR gas/14899
>>>         * Makefile.def (dependencies): Make all-ld and all-gold depend
>>>         on all-gas.
>>>         * Makefile.in: Regenerated.
>>
>> I think a comment would be appropriate since the dependency is obscure.
>>
>> Ian
>
> Does it look OK?
>
> Thanks.
>
>
> --
> H.J.
> --
> 2012-11-30  H.J. Lu  <hongjiu.lu@intel.com>
>
>         PR gas/14899
>         * Makefile.def (dependencies): Make all-binutils, all-gprof,
>         all-ld and all-gold depend on all-gas.
>         * Makefile.in: Regenerated.
> diff --git a/Makefile.def b/Makefile.def
> index 1ea63ac..6724026 100644
> --- a/Makefile.def
> +++ b/Makefile.def
> @@ -370,6 +370,9 @@ dependencies = { module=all-bfd; on=all-intl; };
>  dependencies = { module=configure-opcodes; on=configure-libiberty;
> hard=true; };
>  dependencies = { module=all-opcodes; on=all-libiberty; };
>
> +// We must build gas before binutils, gprof, ld and gold to avoid race
> +// condition in the prev-gcc/as script during bootstrap of combined tree
> +// with GCC and binutils.  See PR gas/14899 for details.
>  dependencies = { module=configure-binutils; on=configure-intl; };
>  dependencies = { module=all-binutils; on=all-libiberty; };
>  dependencies = { module=all-binutils; on=all-opcodes; };

I am checking in this patch.

-- 
H.J.