This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gold/14897: gold is installed as default ld by accident
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 7 Jan 2013 09:06:15 -0800
- Subject: Re: PATCH: PR gold/14897: gold is installed as default ld by accident
- References: <20121130150235.GA7366@intel.com>
On Fri, Nov 30, 2012 at 7:02 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> We should install gold as default ld only for --disable-ld or
> --enable-gold=default. Tested with
>
> --enable-gold
> --enable-gold=default
> --enable-gold --disable-ld
>
> OK for trunk and 2.23?
>
> Thanks.
>
> H.J.
> ---
> 2012-11-30 H.J. Lu <hongjiu.lu@intel.com>
>
> PR gold/14897
> * configure.ac (install_as_default): Set to yes only for
> --disable-ld or --enable-gold=default.
> * configure: Regenerated.
> --- a/gold/configure.ac
> +++ b/gold/configure.ac
> @@ -55,16 +55,20 @@ default_ld=
> AC_ARG_ENABLE(ld,
> [[ --enable-ld[=ARG] build ld [ARG={default,yes,no}]]],
> [case "${enableval}" in
> - default)
> - default_ld=ld.bfd
> - ;;
> -esac])
> + no)
> + default_ld=ld.gold
> + ;;
> + esac])
>
> AC_ARG_ENABLE(gold,
> [[ --enable-gold[=ARG] build gold [ARG={default,yes,no}]]],
> [case "${enableval}" in
> - yes|default)
> - if test x${default_ld} = x; then
> + default)
> + install_as_default=yes
> + installed_linker=ld.gold, Ian Lance Taylor <iant@google.com>
> + ;;
> + yes)
> + if test x${default_ld} != x; then
> install_as_default=yes
> fi
> installed_linker=ld.gold
Hi Ian,
Can you take a look at this patch? This problem shows up when
running "make install" under the gold directory. It isn't a problem
when running "make install" under the toplevel directory since
install-ld depends on install-gold.
Thanks.
--
H.J.