Re: [ping][PATCH] MIPS/GAS: LUI operand handling bug fixes

["Maciej W. Rozycki" <macro at codesourcery dot com>]

On Thu, 1 Nov 2012, Richard Sandiford wrote:

> >  Would you please find a spare moment to have a look at the change below?  
> > Thanks.
> 
> It looks oddly different from the other cases.  We handle:
> 
> 	addiu	$4,$4,foo+1
> 	.eqv	foo,2
> 
> correctly, so I don't see why it must be an error for LUI.

 Obviously silently emitting the operand as zero is worse yet.

> Not that having the above work is particularly important to me.
> It's just the inconsistency that feels wrong.

 I haven't noticed the peculiarity, sorry about that.  I'll see how to 
make the change consistent with how other machine instructions are handled 
(as opposed to assembly macros).  Thanks for your suggestion.

 I think this begs for the overflow checks I mentioned the other day too, 
a piece like:

	addiu	$4,$4,foo+1
	.eqv	foo,0x12345678

should IMHO fail -- do you agree?  I.e. use %lo if this is supposed not to 
overflow:

	addiu	$4,$4,%lo(foo+1)
	.eqv	foo,0x12345678

  Maciej