This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] bi-arch for x86-64 corefile.


On Tue, Oct 30, 2012 at 5:37 AM, Yao Qi <yao@codesourcery.com> wrote:
> On 10/30/2012 03:21 PM, H.J. Lu wrote:
>>
>> I am checking in this.  But sourceware.org times out for me.  Please
>> give it a try.
>>
>
> H.J., it works for me!  Thanks for the review and checking it in.
>
>> diff --git a/bfd/configure b/bfd/configure
>> index fdf5356..427e5c1 100755
>> --- a/bfd/configure
>> +++ b/bfd/configure
>> @@ -13927,6 +13927,10 @@ if test "${target}" = "${host}"; then
>>
>>     i[3-7]86-*-linux-*)
>>         COREFILE=trad-core.lo
>>         TRAD_HEADER='"hosts/i386linux.h"'
>> +       case "$enable_targets" in
>> +       *x86_64-*linux*)
>> +         CORE_HEADER='"hosts/x86-64linux.h"'
>> +       esac
>>
>>         ;;
>>     i[3-7]86-*-isc*)    COREFILE=trad-core.lo ;;
>>     i[3-7]86-*-aix*)    COREFILE=aix386-core.lo ;;
>
>
> This part is a little different from my original patch, which is
>
>
> +       if test x${want64} = xtrue ; then
> +       CORE_HEADER='"hosts/x86-64linux.h"'
> +       fi
>
> This requires something different in configure options.  In my previous
> patch, when configure i686-pc-linux-gnu-gdb to handle bi-arch, we run
> configure with '--enable-64-bit-bfd'.  In current trunk (w/ your patch), we
> have to run configure with '--enable-targets=x86_64-pc-linux-gnu'.

I checked in this patch.

-- 
H.J.
----
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 56b40c5..00f63f2 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2012-10-30  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* configure.in: Also handle --enable-64-bit-bfd when setting
+	CORE_HEADER for 'i[3-7]86-*-linux-*'.
+
 2012-10-30  Steve McIntyre  <steve.mcintyre@linaro.org>

 	* elf32-arm.c (elf32_arm_print_private_bfd_data): Recognise and
diff --git a/bfd/configure b/bfd/configure
index 427e5c1..43bff03 100755
--- a/bfd/configure
+++ b/bfd/configure
@@ -13927,8 +13927,8 @@ if test "${target}" = "${host}"; then
   i[3-7]86-*-linux-*)
 	COREFILE=trad-core.lo
 	TRAD_HEADER='"hosts/i386linux.h"'
-	case "$enable_targets" in
-	*x86_64-*linux*)
+	case "$enable_targets"-"$want64" in
+	*x86_64-*linux*|*-true)
 	  CORE_HEADER='"hosts/x86-64linux.h"'
 	esac
 	;;
diff --git a/bfd/configure.in b/bfd/configure.in
index 9a31c04..6261aab 100644
--- a/bfd/configure.in
+++ b/bfd/configure.in
@@ -331,8 +331,8 @@ changequote(,)dnl
 changequote([,])dnl
 	COREFILE=trad-core.lo
 	TRAD_HEADER='"hosts/i386linux.h"'
-	case "$enable_targets" in
-	*x86_64-*linux*)
+	case "$enable_targets"-"$want64" in
+	*x86_64-*linux*|*-true)
 	  CORE_HEADER='"hosts/x86-64linux.h"'
 	esac
 	;;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]