This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][AARCH64] Fix TLS relocation resolution


On Oct 16, 2012, at 5:46 PM, Marcus Shawcroft wrote:

> On 16/10/12 16:14, Sofiane Naci wrote:
>> Hi,
>> 
>> This patch fixes a bug in the resolution of AArch64 TLS relocations
>> AARCH64_TLSLE_*_TPREL_*.
>> It also fixes wrong shift values for some of the AArch64 TLS relocations in
>> the howto tables.
> 
> The change to shift values and signed_addend look correct to me.  The test added covers R_AARCH64_TLSLE_ADD_TPREL_HI12 and R_AARCH64_TLSLE_ADD_TPREL_LO12 but is missing coverage of the other relocations modified by the patch.
> 
> This addresses a rather nasty issue in the toolchain, have we missed 2.23 ?

Humm, not yet.  I will merge.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]