This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Maintainers file patch for M68HC1x port.


On Tue, 2012-07-24 at 08:13 -0700, Sean Keys wrote:
> Hi,
> 
> Attached is a patch, that adds my contact information, to the 
> binutils/MAINTAINERS file for the M68HC1x port.
> 
> Thanks,
> Sean

That's rather contentious. We've both recently contributed to hc11.

Most of the addition by volume was from me. The code you have
contributed was to support linking in of the xgate additional target you
added.

(We discussed your other patch by email.) I'm still not sure I can think
of a case where a symbol would be created in XGATE space that needs to
be referenced by the S12, but the check you've added for that case is
likely harmless.

However, it would be worth adding some testcases to the testsuite to
confirm the new behaviour.  

regards

James


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]