This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Simplify global symbol handling
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Date: Fri, 29 Jun 2012 10:36:56 -0700
- Subject: Re: PATCH: Simplify global symbol handling
- References: <20120629170018.GA3862@intel.com>
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
On Fri, Jun 29, 2012 at 10:00:18AM -0700, H.J. Lu wrote:
> Hi,
>
> I checked in this patch to simplify global symbol handling.
>
>
I checked in another one.
H.J.
---
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1afd7e4..9ea3a1e 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2012-06-29 H.J. Lu <hongjiu.lu@intel.com>
+
+ * archive.c (_bfd_compute_and_write_armap): Simplify global
+ symbol handling.
+
2012-06-29 Nick Clifton <nickc@redhat.com>
PR ld/14189
diff --git a/bfd/archive.c b/bfd/archive.c
index 26547ba..0620452 100644
--- a/bfd/archive.c
+++ b/bfd/archive.c
@@ -2314,10 +2314,10 @@ _bfd_compute_and_write_armap (bfd *arch, unsigned int elength)
flagword flags = (syms[src_count])->flags;
asection *sec = syms[src_count]->section;
- if ((flags & BSF_GLOBAL
- || flags & BSF_WEAK
- || flags & BSF_INDIRECT
- || flags & BSF_GNU_UNIQUE
+ if (((flags & (BSF_GLOBAL
+ | BSF_WEAK
+ | BSF_INDIRECT
+ | BSF_GNU_UNIQUE)) != 0
|| bfd_is_com_section (sec))
&& ! bfd_is_und_section (sec))
{