This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch] Fix build warnings for GAS on mips-linux-gnu
On Mon, Jun 18, 2012 at 01:52:18PM +0930, Alan Modra wrote:
> On Tue, Jun 12, 2012 at 07:39:58PM +0100, Iain Sandoe wrote:
> > P.S. As an aside, is it intentional that the fall-back specifications are not proper prototypes?
>
> Yes. It saves trouble with "const char *" vs. "char *", "unsigned
> long" vs. "unsigned int" and the like differences when we provide a
> declaration that doesn't match some system header declaration.
>
> > * configure.in: Check DECLS for free, getenv, malloc, realloc,
> > stpcpy and strstr.
> > * configure: Regenerate.
> > * config.in: Likewise.
>
> I'm applying this one instead as it saves a few lines in the generated
> configure.
Having thus demonstrated conclusively that I'm a complete idiot..
Fix the breakage with the following.
Index: gas/configure.in
===================================================================
RCS file: /cvs/src/src/gas/configure.in,v
retrieving revision 1.231
diff -u -p -r1.231 configure.in
--- gas/configure.in 18 Jun 2012 04:23:11 -0000 1.231
+++ gas/configure.in 18 Jun 2012 04:36:16 -0000
@@ -663,7 +663,7 @@ AC_C_INLINE
# VMS doesn't have unlink.
AC_CHECK_FUNCS(unlink remove, break)
-AC_CHECK_FUNCS(free getenv malloc realloc sbrk setlocale stpcpy strstr)
+AC_CHECK_FUNCS(sbrk setlocale)
AM_LC_MESSAGES
@@ -727,8 +727,7 @@ GAS_CHECK_DECL_NEEDED(malloc, f, char *(
GAS_CHECK_DECL_NEEDED(sbrk, f, char *(*f)(), $gas_test_headers)
GAS_CHECK_DECL_NEEDED(strstr, f, char *(*f)(), $gas_test_headers)
-AC_CHECK_DECLS([mempcpy])
-AC_CHECK_DECLS([vsnprintf])
+AC_CHECK_DECLS([free, getenv, malloc, mempcpy, realloc, stpcpy, strstr, vsnprintf])
BFD_BINARY_FOPEN
--
Alan Modra
Australia Development Lab, IBM