This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Allocate sufficient space for string buffer

From: Alan Modra <amodra at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Fri, 8 Jun 2012 13:20:50 +0930
Subject: Re: PATCH: Allocate sufficient space for string buffer
References: <20120607185845.GA24095@intel.com> <20120608020907.GH5117@bubble.grove.modra.org> <CAMe9rOpBSJ30gpG+=SWRZfF34oDgeJBbzh3TwnmO4Ddw+sJWfA@mail.gmail.com>

On Thu, Jun 07, 2012 at 07:36:31PM -0700, H.J. Lu wrote:
> If ptr->len + len == ptr->max, we double the size.
> Should it be changed to
> 
> while (ptr->len + len > max)

Err, yes.  ptr->max doesn't take into account the terminator.

-- 
Alan Modra
Australia Development Lab, IBM

References:
- PATCH: Allocate sufficient space for string buffer
  - From: H.J. Lu
- Re: PATCH: Allocate sufficient space for string buffer
  - From: Alan Modra
- Re: PATCH: Allocate sufficient space for string buffer
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]