This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch]Fix gold build on MacOSX Xcode 3.2.6
Thanks!
2012-06-05 Jing Yu <jingyu@google.com>
* gold.h (textdomain): Add do {} to empty while(0).
(bindtextdomain): Likewise.
Index: gold/gold.h
===================================================================
RCS file: /cvs/src/src/gold/gold.h,v
retrieving revision 1.47
diff -u -r1.47 gold.h
--- gold/gold.h 8 Jun 2011 04:43:28 -0000 1.47
+++ gold/gold.h 5 Jun 2012 19:40:24 -0000
@@ -58,8 +58,8 @@
# define gettext(Msgid) (Msgid)
# define dgettext(Domainname, Msgid) (Msgid)
# define dcgettext(Domainname, Msgid, Category) (Msgid)
-# define textdomain(Domainname) while (0) /* nothing */
-# define bindtextdomain(Domainname, Dirname) while (0) /* nothing */
+# define textdomain(Domainname) do {} while (0) /* nothing */
+# define bindtextdomain(Domainname, Dirname) do {} while (0) /* nothing */
On Tue, Jun 5, 2012 at 1:04 PM, Ian Lance Taylor <iant@google.com> wrote:
> Jing Yu <jingyu@google.com> writes:
>
>> 2012-06-05 ?Jing Yu ?<jingyu@google.com>
>>
>> ? ? ? ?* gold.h (textdomain): Add do {} to empty while(0)
>> ? ? ? ? ? ? ? ? ? ? ?(bindtextdomain): Likewise
>
> Don't indent the second line of the ChangeLog--see the other entries.
> Also, add a period at the end of each line.
>
> This is OK with those changes.
>
> Thanks.
>
> Ian