This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: INPUT_SECTION_FLAGS broken (Was: [RFA] PowerPC VLE port)
- From: James Lemke <jwlemke at codesourcery dot com>
- To: <binutils at sourceware dot org>
- Cc: Catherine Moore <clm at codesourcery dot com>, "Maciej W. Rozycki" <macro at codesourcery dot com>, Rhonda Wittels <rhonda at CodeSourcery dot com>
- Date: Wed, 9 May 2012 09:01:01 -0400
- Subject: Re: INPUT_SECTION_FLAGS broken (Was: [RFA] PowerPC VLE port)
- References: <20110813114725.GH19463@bubble.grove.modra.org> <4F47BE0C.1000706@mentor.com> <20120301124020.GA3468@bubble.grove.modra.org> <4F8C3A3C.9020602@codesourcery.com> <4F8DAF72.2000901@codesourcery.com> <20120420065128.GT3218@bubble.grove.modra.org> <4F91C623.60505@codesourcery.com> <20120421044734.GW3218@bubble.grove.modra.org> <20120421064331.GZ3218@bubble.grove.modra.org> <4FA979F0.1050202@codesourcery.com> <20120509035350.GT17181@bubble.grove.modra.org>
What if you're disassembling a ppc64 object file where sec_flg2 has a
different meaning? Fix this by passing info->section to a predicate
function living in elf32-ppc.c something along the lines of
bfd_boolean
is_ppc_vle (asection *sec)
{
return (sec->owner != NULL
&& is_ppc_elf (sec->owner)
&& sec->has_vle_insns);
}
Declare in, I dunno, elf32-ppc.h preferably but this will require
you to pull other headers into ppc-dis.h. elf-bfd.h as a last resort.
Thanks for the comments, I'll look at it this now.
Also
-/* This bit is reserved by BFD for processor specific stuff. Name
- it properly so that we can easily stay consistent elsewhere. */
-#define SEC_PPC_VLE SEC_TIC54X_BLOCK
went quite a while ago, which you'll discover when you try to commit
the patch. Please fix corresponding changelog.
I disagree.. the patch was generated via: cvs diff with a recent checkout.
I just did another checkout and these lines are present.
They can also be seen here:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/elf/ppc.h?rev=1.30&content-type=text/x-cvsweb-markup&cvsroot=src
Somehow you & I are out of sync!?
Jim.
--
Jim Lemke
Mentor Graphics / CodeSourcery
Orillia Ontario, +1-613-963-1073