This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 3/3] gold: Handle DW_AT_high_pc as offset from DW_AT_low_pc in gdb-index.cc.
- From: Ian Lance Taylor <iant at google dot com>
- To: Mark Wielaard <mjw at redhat dot com>
- Cc: Cary Coutant <ccoutant at google dot com>, binutils at sourceware dot org, jakub at redhat dot com, Ian Lance Taylor <ian at airs dot com>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Doug Kwan <dougkwan at google dot com>
- Date: Tue, 01 May 2012 11:38:32 -0700
- Subject: Re: [PATCH 3/3] gold: Handle DW_AT_high_pc as offset from DW_AT_low_pc in gdb-index.cc.
- References: <1335528921-11582-1-git-send-email-mjw@redhat.com> <1335528921-11582-4-git-send-email-mjw@redhat.com> <CAHACq4rmNEgqyaAGESCkk1PBZ2F7Vk7eJeUjHjR_S_rCjQB9Nw@mail.gmail.com> <1335565978.29213.52.camel@springer.wildebeest.org>
Mark Wielaard <mjw@redhat.com> writes:
> 2012-04-26 Mark Wielaard <mjw@redhat.com>
>
> * dwarf_reader.cc (Dwarf_die::address_attribute): New function.
> * dwarf_reader.h (Dwarf_die::address_attribute): Likewise.
> * gdb-index.cc (Gdb_index_info_reader::record_cu_ranges): Handle
> DW_AT_high_pc as offset from DW_AT_low_pc.
>
> * testsuite/Makefile.am (gdb_index_test_3.sh): New test case.
> * testsuite/Makefile.in: Regenerate.
> * testsuite/gdb_index_test_3.c: New test source file.
> * testsuite/gdb_index_test_3.sh: New test source file.
> diff --git a/gold/dwarf_reader.h b/gold/dwarf_reader.h
> index 0c3dab6..6baef66 100644
> --- a/gold/dwarf_reader.h
> +++ b/gold/dwarf_reader.h
> @@ -550,6 +550,11 @@ class Dwarf_die
> ref_attribute(unsigned int attr,
> unsigned int* shndx);
>
> + // Return the value of attribute ATTR as a address.
> + off_t
> + address_attribute(unsigned int attr,
> + unsigned int* shndx);
Looks like you can bring shndx up to the previous line here.
This is OK with that change.
Thanks.
Ian