This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch ld]: Fix duplicates in export-table due missing set of is_ident.
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Binutils <binutils at sourceware dot org>
- Cc: Nick Clifton <nickc at redhat dot com>
- Date: Mon, 13 Feb 2012 13:49:32 +0100
- Subject: Re: [patch ld]: Fix duplicates in export-table due missing set of is_ident.
- References: <CAEwic4Z3T7k21gwv_nY_cAObqz+=REEpogkiu5vPsNZbwV0bpA@mail.gmail.com>
Hi,
I missed here the import-case, so I resent. This patch avoids
double-entries for first or last element search. We missed
to set for identity is_indent in those cases.
ChangeLog
2012-02-13 Kai Tietz <ktietz@redhat.com>
* deffilep.y (find_export_in_list): Set is_indent for
first or last element, if identical.
(find_import_in_list): Likewise.
ested for i686-w64-mingw32, and x86_64-w64-mingw32. Ok for apply?
Regards,
Kai
Index: deffilep.y
===================================================================
RCS file: /cvs/src/src/ld/deffilep.y,v
retrieving revision 1.37
diff -r1.37 deffilep.y
625c625,629
< return 0;
---
> {
> if (!e)
> *is_ident = 1;
> return 0;
> }
631c635,639
< return max - 1;
---
> {
> if (!e)
> *is_ident = 1;
> return max - 1;
> }
760c768,772
< return 0;
---
> {
> if (!e)
> *is_ident = 1;
> return 0;
> }
766c778,782
< return max - 1;
---
> {
> if (!e)
> *is_ident = 1;
> return max - 1;
> }