This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
+static char * +obj_mach_o_maybe_quoted_canonical_section_name (char *bf)
Looks like a little bit far-fetch. So we accept '.pushsection .text' but not '.section .text' ?
You really need to document the use of BF and the return value. Why 255 ? A constant would be better IMHO.yes it would - will do.
+# { dg-warning ".popsection without corresponding .pushsection; ignored" "" { target *-*-darwin*} 5 }
Otherwise OK, but I am a bit dubious about the use of it.
WDYT? Iain
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |