This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] FIx mips PR 13509: not all labels are moved


Hi the comment before mips_align in gas/config/tc-mips.c says any
preceding label before an align will be moved.  But currently it only
moves the first preceding label.  This can cause confusing behavior
when you add an extra label or two and those are not moved.  This also
can cause different produced object code when gcc generates -g vs -g0
code because of the placement of the labels.  It had caused a gcc
bootstrap miscompare with a modified gcc.

OK?  Tested on mips64-linux-gnu with no regressions.

Thanks,
Andrew Pinski

gas/ChangeLog:
* tc-mips.c (mips_align): Take the labels rather than just one label.
Move all labels to after the .align.
(s_align): Change the last argument to mips_align.
(s_cons): Likewise.
(s_float_cons): Likewise.
(s_gpword): Likewise.
(s_gpdword): Likewise.

Attachment: fixlabels.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]