Re: Ping: [RFA]: New port: Epiphany

[Joern Rennecke <amylaar at spamcop dot net>]

Quoting Nick Clifton <nickc@redhat.com>:

> Hi Joern,
>
> > This patch hasn't been reviewed for more than a week:
> > http://sourceware.org/ml/binutils/2011-10/msg00090.html
>
> Sorry - I am very behind on my patch reviews at the moment.
>
> Note that there are still a couple of missing files
> (gas/config/tc-epiphany.[ch], gas/doc/c-epiphany.c,
> include/elf/epiphany.h, cpu/epiphany.{cpu|opc}), so I have not been
> able to build the target for myself and check it.

These files are all included in the epiphany-binutils-20111012.tar.bz2
attachment of the above linked posting.  Well, except that the gas
documentation file is called c-epiphany.texi, of course:

$ tar tvjf epiphany-binutils-20111012.tar.bz2
-rw-r--r-- amylaar/amylaar 2107 2011-10-09 18:51 bfd/cpu-epiphany.c
-rw-r--r-- amylaar/amylaar 28782 2011-10-09 15:17 bfd/elf32-epiphany.c
-rwxr-xr-x amylaar/amylaar 28731 2011-10-09 17:42 gas/config/tc-epiphany.c
-rwxr-xr-x amylaar/amylaar  3342 2011-10-09 17:43 gas/config/tc-epiphany.h
-rw-r--r-- amylaar/amylaar  1832 2011-10-12 19:34 gas/doc/c-epiphany.texi
-rw-rw-r-- amylaar/amylaar   313 2011-10-09 21:01  
gas/testsuite/gas/epiphany/addr-syntax.d
-rw-rw-r-- amylaar/amylaar   260 2011-10-09 18:17  
gas/testsuite/gas/epiphany/addr-syntax.s
-rw-rw-r-- amylaar/amylaar 41393 2011-10-11 16:07  
gas/testsuite/gas/epiphany/allinsn.d
-rw-rw-r-- amylaar/amylaar   360 2011-10-09 18:24  
gas/testsuite/gas/epiphany/allinsn.exp
-rw-rw-r-- amylaar/amylaar 21202 2011-10-09 18:08  
gas/testsuite/gas/epiphany/allinsn.s
-rw-rw-r-- amylaar/amylaar   373 2011-10-09 18:05  
gas/testsuite/gas/epiphany/badpostmod.s
-rw-rw-r-- amylaar/amylaar   190 2011-08-02 06:32  
gas/testsuite/gas/epiphany/badrelax.d
-rw-rw-r-- amylaar/amylaar    52 2011-10-09 18:07  
gas/testsuite/gas/epiphany/badrelax.s
-rw-rw-r-- amylaar/amylaar   157 2011-08-02 06:32  
gas/testsuite/gas/epiphany/branch_lit.d
-rw-rw-r-- amylaar/amylaar     9 2011-08-02 06:32  
gas/testsuite/gas/epiphany/branch_lit.s
-rw-rw-r-- amylaar/amylaar  7470 2011-10-11 16:08  
gas/testsuite/gas/epiphany/regression.d
-rw-rw-r-- amylaar/amylaar  6161 2011-10-09 18:08  
gas/testsuite/gas/epiphany/regression.s
-rw-rw-r-- amylaar/amylaar  5526 2011-10-11 16:09  
gas/testsuite/gas/epiphany/sample.d
-rwxrwxr-x amylaar/amylaar  1537 2011-10-09 18:07  
gas/testsuite/gas/epiphany/sample.s
-rwxr-xr-x amylaar/amylaar  2081 2011-10-09 14:35 include/elf/epiphany.h
-rw-r--r-- amylaar/amylaar  1169 2011-10-09 18:42  
ld/emulparams/elf32epiphany.sh
-rw-r--r-- amylaar/amylaar 25327 2011-10-09 19:40 opcodes/epiphany-asm.c
-rw-r--r-- amylaar/amylaar 83924 2011-10-09 19:40 opcodes/epiphany-desc.c
-rw-r--r-- amylaar/amylaar 19932 2011-10-09 19:40 opcodes/epiphany-desc.h
-rw-r--r-- amylaar/amylaar 21997 2011-10-09 19:40 opcodes/epiphany-dis.c
-rw-r--r-- amylaar/amylaar 51379 2011-10-09 19:40 opcodes/epiphany-ibld.c
-rw-r--r-- amylaar/amylaar 120527 2011-10-11 21:27 opcodes/epiphany-opc.c
-rw-r--r-- amylaar/amylaar   8643 2011-10-09 19:40 opcodes/epiphany-opc.h
-rw-r--r-- amylaar/amylaar  80751 2011-10-11 21:27 cpu/epiphany.cpu
-rwxr-xr-x amylaar/amylaar  10624 2011-10-09 13:56 cpu/epiphany.opc

I'll look into the other issues you raise.

>  Plus the comment formatting really ought to the follow the
> GNU Coding Standard.

Is there any tool to flag up mis-formatted comments?  I've re-formatted
some code and comments before, but obviously I've missed some.