This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[Patch] gas/alpha: make out of range relocs an error
- From: Tristan Gingold <gingold at adacore dot com>
- To: binutils Development <binutils at sourceware dot org>
- Cc: Richard Henderson <rth at redhat dot com>
- Date: Fri, 9 Sep 2011 16:36:22 +0200
- Subject: [Patch] gas/alpha: make out of range relocs an error
Hi,
currently on alpha, out of range relocs are diagnosed as a warning. I think this is not the right choice as a warning can be easily missed during a compilation, and a relocation overflow will mostly result in a broken executable.
So for alpha, I propose to make reloc overflow an error.
Is it OK ?
Tristan.
gas/
2011-09-09 Tristan Gingold <gingold@adacore.com>
* config/tc-alpha.c (insert_operand): Call as_bad_value_out_of_range
instead of as_warn_out_of_range.
diff --git a/gas/config/tc-alpha.c b/gas/config/tc-alpha.c
index c9634b7..4f21fb3 100644
--- a/gas/config/tc-alpha.c
+++ b/gas/config/tc-alpha.c
@@ -1995,7 +1995,7 @@ insert_operand (unsigned insn,
}
if (val < min || val > max)
- as_warn_value_out_of_range (_("operand"), val, min, max, file, line);
+ as_bad_value_out_of_range (_("operand"), val, min, max, file, line);
}
if (operand->insert)