This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gold patch committed: Add unwind descriptors for PLT entries


Jakub Jelinek <jakub@redhat.com> writes:

> On Fri, Jul 01, 2011 at 03:06:15PM -0700, Ian Lance Taylor wrote:
>> +  elfcpp::DW_CFA_def_cfa_offset, 8,	// DW_CFA_def_cfa_offset: 8.
>> +  elfcpp::DW_CFA_advance_loc + 6,	// Advance 6 to __PLT__ + 6.
>> +  elfcpp::DW_CFA_def_cfa_offset, 12,	// DW_CFA_def_cfa_offset: 12.
>> +  elfcpp::DW_CFA_advance_loc + 10,	// Advance 10 to __PLT__ + 16.
>> +  elfcpp::DW_CFA_def_cfa_expression,	// DW_CFA_def_cfa_expression.
>> +  11,					// Block length.
>> +  elfcpp::DW_OP_breg4, 4,		// Push %esp + 4.
>> +  elfcpp::DW_OP_breg8, 0,		// Push %eip.
>> +  elfcpp::DW_OP_lit15,			// Push 0xf.
>> +  elfcpp::DW_OP_and,			// & (%eip & 0xf).
>> +  elfcpp::DW_OP_lit11,			// Push 0xb.
>> +  elfcpp::DW_OP_ge,			// >= ((%eip & 0xf) >= 0xb)
>> +  elfcpp::DW_OP_lit2,			// Push 2.
>> +  elfcpp::DW_OP_shl,			// << (((%eip & 0xf) >= 0xb) << 2)
>> +  elfcpp::DW_OP_plus,			// + ((((%eip&0xf)>=0xb)<<2)+%esp+8
>
> The above comment is wrong, it is actually
> 						// + ((((%eip&0xf)>=0xb)<<2)+%esp+4


Thanks, corrected.

I didn't bother to add a new ChangeLog entry since this was just a minor
tweak to the last commit.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]