This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] Incremental 21/22: Return exit status 2 for fallback to --incremental-full
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 07 Jun 2011 17:41:36 -0700
- Subject: Re: [gold patch] Incremental 21/22: Return exit status 2 for fallback to --incremental-full
- References: <BANLkTik_3r_VUCJPasRYPabUGMjvg93PwA@mail.gmail.com>
Cary Coutant <ccoutant@google.com> writes:
> 2011-05-02 Cary Coutant <ccoutant@google.com>
>
> * common.cc (Symbol_table::do_allocate_commons_list): Call
> gold_fallback.
> * errors.cc (Errors::fatal): Adjust call to gold_exit.
> (Errors::fallback): New function.
> (gold_fallback): New function.
> * errors.h (Errors::fallback): New function.
> * gold.cc (gold_exit): Change status parameter to enum; adjust
> all callers.
> (queue_initial_tasks): Call gold_fallback.
> * gold.h: Include cstdlib.
> (Exit_status): New enum type.
> (gold_exit): Change status parameter to enum.
> (gold_fallback): New function.
> * layout.cc (Layout::set_section_offsets): Call gold_fallback.
> (Layout::create_symtab_sections): Likewise.
> (Layout::create_shdrs): Likewise.
> * main.cc (main): Adjust call to gold_exit.
> * output.cc (Output_section::add_input_section): Call gold_fallback.
> (Output_section::add_output_section_data): Likewise.
> (Output_segment::set_section_list_addresses): Likewise.
> * output.h (Output_data_got::add_got_entry): Likewise.
> (Output_data_got::add_got_entry_pair): Likewise.
> * x86_64.cc (Output_data_plt_x86_64::add_entry): Likewise.
> diff --git a/gold/gold.h b/gold/gold.h
> index 158f63b..06ab25b 100644
> --- a/gold/gold.h
> +++ b/gold/gold.h
> @@ -27,6 +27,7 @@
> #include "ansidecl.h"
>
> #include <cstddef>
> +#include <cstdlib>
I can't see any reason for this. Omit it if it's not needed.
This is OK with that change.
Thanks.
Ian