Re: [gold patch] Incremental 15/18: Add --incremental-base option.

[Cary Coutant <ccoutant at google dot com>]

>> You're going to some mild contortions to map in the base file, and then
>> you are throwing away the mapping. ?If you are going to stick with this
>> copying approach, then I think it would be simpler to just map the
>> output file as for a non-incremental link, and then open() the base file
>> and read() the contents into the mapping you just created. ?That will be
>> just as efficient--it's a nice sequential read--and will save you from
>> running out of memory when you in effect map the output file twice.
>
> Argh, good point. I'll rework this.

Revised patch attached.

-cary


2011-05-24 Cary Coutant  <ccoutant@google.com>

	* gold.cc (queue_initial_tasks): Pass incremental base filename
	to Output_file::open_base_file; don't print error message.
	* incremental-dump.cc (main): Adjust call to
	Output_file::open_for_modification.
	* incremental-dump.cc (main): Likewise.
	* incremental.cc (Incremental_inputs::report_command_line):
	Ignore --incremental-base option when comparing command lines.
	Ignore parameter when given as separate argument.
	* options.h (class General_options): Add --incremental-base.
	* output.cc (Output_file::Output_file):
	(Output_file::open_base_file): Add base_name and writable parameters;
	read base file into new file; print error message here.
	(Output_file::map_no_anonymous): Add writable parameter; adjust all
	callers.
	* output.h (Output_file::open_for_modification): Rename to...
	(Output_file::open_base_file): ...this; add base_name and
	writable parameters; adjust all callers.
	(Output_file::map_no_anonymous): Add writable parameter; adjust all
	callers.
	* testsuite/Makefile.am (incremental_test_4): Test
	--incremental-base.
	* testsuite/Makefile.in: Regenerate.

Attachment: incr-patch-15c.txt
Description: Text document