This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix PR12763, .tbss mishandling
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: binutils at sourceware dot org
- Date: Sat, 21 May 2011 03:48:58 +0200
- Subject: Re: Fix PR12763, .tbss mishandling
> Date: Fri, 20 May 2011 19:26:46 +0200
> From: Hans-Peter Nilsson <hp@axis.com>
> > Date: Sat, 21 May 2011 01:07:23 +0930
> > From: Alan Modra <amodra@gmail.com>
>
> > PR 12763
> This change caused, for cris-axis-elf and cris-axis-linux-gnu:
>
> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-cris/cris.exp ...
> FAIL: ld-cris/tls-e-tpoffcomm1
And after a slightly closer inspection, the fix is as expected
to adjust for the removed empty program header, thus:
ld/testsuite:
* ld-cris/tls-e-tpoffcomm1.d: Adjust for PR12763 change removing
empty program header.
Committed.
Index: ld-cris/tls-e-tpoffcomm1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/tls-e-tpoffcomm1.d,v
retrieving revision 1.1
diff -p -u -r1.1 tls-e-tpoffcomm1.d
--- ld-cris/tls-e-tpoffcomm1.d 25 Mar 2009 03:04:21 -0000 1.1
+++ ld-cris/tls-e-tpoffcomm1.d 21 May 2011 01:43:51 -0000
@@ -11,35 +11,33 @@
Program Header:
LOAD off 0x0+ vaddr 0x0+80000 paddr 0x0+80000 align 2\*\*13
- filesz 0x0+a4 memsz 0x0+a4 flags r-x
- LOAD off 0x0+a4 vaddr 0x0+820a4 paddr 0x0+820a4 align 2\*\*13
- filesz 0x0+ memsz 0x0+ flags rw-
- TLS off 0x0+a4 vaddr 0x0+820a4 paddr 0x0+820a4 align 2\*\*2
+ filesz 0x0+84 memsz 0x0+84 flags r-x
+ TLS off 0x0+ vaddr 0x0+82084 paddr 0x0+82084 align 2\*\*2
filesz 0x0+ memsz 0x0+8 flags r--
private flags = 0:
Sections:
Idx Name Size VMA LMA File off Algn
- 0 .text 0+10 0+80094 0+80094 0+94 2\*\*1
+ 0 .text 0+10 0+80074 0+80074 0+74 2\*\*1
CONTENTS, ALLOC, LOAD, READONLY, CODE
- 1 .tbss 0+8 0+820a4 0+820a4 0+a4 2\*\*2
+ 1 .tbss 0+8 0+82084 0+82084 0+ 2\*\*2
ALLOC, THREAD_LOCAL
SYMBOL TABLE:
-0+80094 l d .text 0+ .text
-0+820a4 l d .tbss 0+ .tbss
-0+80098 l F .text 0+c do_test
-0+80094 g .text 0+ _start
-0+820a4 g \*ABS\* 0+ __bss_start
+0+80074 l d .text 0+ .text
+0+82084 l d .tbss 0+ .tbss
+0+80078 l F .text 0+c do_test
+0+80074 g .text 0+ _start
+0+82084 g \*ABS\* 0+ __bss_start
0+ g .tbss 0+4 foo
-0+820a4 g \*ABS\* 0+ _edata
-0+820c0 g \*ABS\* 0+ _end
+0+82084 g \*ABS\* 0+ _edata
+0+820a0 g \*ABS\* 0+ _end
0+4 g .tbss 0+4 bar
#...
Disassembly of section .text:
-00080094 <_start>:
- 80094: 41b2 moveq 1,\$r11
+00080074 <_start>:
+ 80074: 41b2 moveq 1,\$r11
#...
-00080098 <do_test>:
- 80098: 2f0e f8ff ffff add.d 0xfffffff8,\$r0
- 8009e: 2f1e fcff ffff add.d 0xfffffffc,\$r1
+00080078 <do_test>:
+ 80078: 2f0e f8ff ffff add.d 0xfffffff8,\$r0
+ 8007e: 2f1e fcff ffff add.d 0xfffffffc,\$r1
brgds, H-P