This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix BSD build regression on core file's PID
- From: Alan Modra <amodra at gmail dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: binutils at sourceware dot org, Andreas Tobler <andreast-list at fgznet dot ch>
- Date: Thu, 12 May 2011 11:00:51 +0930
- Subject: Re: [patch] Fix BSD build regression on core file's PID
- References: <20110511215636.GA22274@host1.jankratochvil.net>
On Wed, May 11, 2011 at 11:56:36PM +0200, Jan Kratochvil wrote:
> (HAVE_ELFCORE_PSINFO_T_PR_PID, HAVE_ELFCORE_PSINFO32_T_PR_PID): Set
> them if appropriate.
I think the code would be clearer without these two new macros.
ie. Keep with existing practice in elfcore_grok_psinfo and use
#if defined (HAVE_PSINFO_T_PR_PID) || defined (HAVE_PRPSINFO_T_PR_PID)
and
#if defined (HAVE_PSINFO32_T_PR_PID) || defined (HAVE_PRPSINFO32_T_PR_PID)
instead. OK with that change.
--
Alan Modra
Australia Development Lab, IBM