This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, GAS, ARM]. Warn on Erratum 752419.

From: Nick Clifton <nickc at redhat dot com>
To: Tejas Belagod <tejas dot belagod at arm dot com>
Cc: binutils at sourceware dot org
Date: Wed, 11 May 2011 10:29:17 +0100
Subject: Re: [PATCH, GAS, ARM]. Warn on Erratum 752419.
References: <1304698580.21908.108.camel@e102484-lin.cambridge.arm.com>

Hi Tejas,

	* config/tc-arm.c(do_t_ldst): Warn on loading into sp with
	writeback for appropriate cores/arch.
	* testsuite/gas/arm/ld-sp-warn-cortex-m3.d: New test.
	* testsuite/gas/arm/ld-sp-warn-cortex-m3.l: New test.
	* testsuite/gas/arm/ld-sp-warn-cortex-m4.d: New test.
	* testsuite/gas/arm/ld-sp-warn-cortex-m4.l: New test.
	* testsuite/gas/arm/ld-sp-warn-v7.d: New test.
	* testsuite/gas/arm/ld-sp-warn-v7.l: New test.
	* testsuite/gas/arm/ld-sp-warn-v7a.d: New test.
	* testsuite/gas/arm/ld-sp-warn-v7a.l: New test.
	* testsuite/gas/arm/ld-sp-warn-v7e-m.l: New test.
	* testsuite/gas/arm/ld-sp-warn-v7em.d: New test.
	* testsuite/gas/arm/ld-sp-warn-v7m.d: New test.
	* testsuite/gas/arm/ld-sp-warn-v7m.l: New test.
	* testsuite/gas/arm/ld-sp-warn-v7r.d: New test.
	* testsuite/gas/arm/ld-sp-warn-v7r.l: New test.
	* testsuite/gas/arm/ld-sp-warn.s: New test.

Approved and applied. I made two changes however - firstly there is a separate ChangeLog for gas testsuite additions, so I moved your changelog entry there. Secondly all of your new tests had the same text in their "name:" entry, so if one of them failed it would not be immediately obvious which one was at fault. Thus I added a architecture name in parentheses to the text so that you can tell them apart.

Cheers
  Nick

References:
- [PATCH, GAS, ARM]. Warn on Erratum 752419.
  - From: Tejas Belagod

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]