This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS/GAS: Fix register use annotation of ALNV.PS
On Sat, 26 Feb 2011, Richard Sandiford wrote:
> > The ALNV.PS instruction lacks register use annotation for its general
> > register argument. As a result it can be reordered into a branch delay
> > slot even if it reads a register that the branch writes. Here's a fix.
>
> Ouch. So easily done. Did someone find out the hard way, or was this
> just by inspection?
The microMIPS version of ALNV.PS is enough of an oddball that I couldn't
resist checking we've got the standard version right either. ;)
> > 2011-02-25 Maciej W. Rozycki <macro@codesourcery.com>
> >
> > opcodes/
> > * mips-opc.c (mips_builtin_opcodes): Correct register use
> > annotation of "alnv.ps".
> >
> > gas/testsuite/
> > * gas/mips/alnv_ps-swap.d: New test for ALNV.PS instruction
> > branch swapping.
> > * gas/mips/alnv_ps-swap.s: Source for the new test.
> > * gas/mips/mips.exp: Run the new test.
>
> OK, thanks.
It's now in, thanks.
Maciej