This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed] MIPS/GAS: Remove duplicate initialisation of offset_reloc
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: binutils at sourceware dot org
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Mon, 21 Feb 2011 23:27:05 +0000 (GMT)
- Subject: [committed] MIPS/GAS: Remove duplicate initialisation of offset_reloc
Hello,
The change below removes duplicate initialisation of offset_reloc
currently made in the handler of the 'o' format specifier. There is
exactly the same sequence of three assignments repeated immediately before
the comment seen in the patch below (and the comment applies to the
conditional).
Committed as obvious.
2011-02-21 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (mips_ip) <'o'>: Remove duplicate
initialization of offset_reloc.
Maciej
binutils-gas-mips-fix-offset-reloc.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2011-02-21 21:33:26.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2011-02-21 21:34:04.000000000 +0000
@@ -11907,9 +11907,6 @@ mips_ip (char *str, struct mips_cl_insn
/* Check whether there is only a single bracketed expression
left. If so, it must be the base register and the
constant must be zero. */
- offset_reloc[0] = BFD_RELOC_LO16;
- offset_reloc[1] = BFD_RELOC_UNUSED;
- offset_reloc[2] = BFD_RELOC_UNUSED;
if (*s == '(' && strchr (s + 1, '(') == 0)
{
offset_expr.X_op = O_constant;