This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] AMD bdver2 processors 1/2 - BMI


On Mon, Dec 20, 2010 at 5:24 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> Hi Quentin,
> There is no need for the extra parentheses in:
>
> + ? ? ?if ((i.tm.opcode_modifier.vexsources == XOP2SOURCES)
> + ? ? ? ? ?|| (i.tm.opcode_modifier.vexsources == XOP2REVSOURCES))
>
> + ? ? ? ? ? ? ?if ((i.tm.opcode_modifier.vexsources == XOP2SOURCES)
> + ? ? ? ? ? ? ? ? ?&& (i.tm.opcode_modifier.vexw == VEXW0))
>
> + ? ? ? ? ? ? ?if ((i.tm.opcode_modifier.vexsources == XOP2SOURCES)
> + ? ? ? ? ? ? ? ? ?&& (i.tm.opcode_modifier.vexw == VEXW0))
>
> Then there is this change that does not appear in the ChangeLog:
>
> - ? ? ?else if (i.tm.opcode_modifier.vexvvvv == VEXLWP)
> + ? ? ?else if (i.tm.opcode_modifier.vexvvvv == VEXVRM)
>
> Please add something like "(VEXLWP): Renamed VEXVRM." both in the
> gas/ChangeLog and in opcodes/ChangeLog.
>
> Otherwise the patch looks good to me, but I cannot approve it.
>
> Thanks,
> Sebastian

Fixed as recommended.  Passes "make -k check RUNTESTFLAGS=i386.exp".

Okay to commit?
-- 
Quentin

Attachment: 7039_bdver2_bmi.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]