This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: Catherine Moore <clm at codesourcery dot com>, binutils at sourceware dot org
- Date: Thu, 9 Dec 2010 22:53:04 +0000 (GMT)
- Subject: Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
- References: <alpine.DEB.1.10.1012020105230.14129@tp.orcam.me.uk> <87zkshao0u.fsf@firetop.home>
On Tue, 7 Dec 2010, Richard Sandiford wrote:
> Like Paul, I think the first order ("expression is not in the range A..B")
> sounds more natural. There again, the liberal dropping of words makes
> the thing sound wrong whatever we do.
>
> Patch is OK with the original word order.
Can't argue with a native English speaker. ;) This is what I applied,
thanks.
2010-12-09 Maciej W. Rozycki <macro@codesourcery.com>
* config/tc-mips.c (mips_ip) <'u'>: Report the value of the LUI
argument complained about; reword the message.
Maciej
binutils-gas-mips-msg-lui.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2010-12-09 02:34:52.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2010-12-09 02:34:53.000000000 +0000
@@ -10014,7 +10014,8 @@ mips_ip (char *str, struct mips_cl_insn
&& imm_expr.X_op == O_constant
&& (imm_expr.X_add_number < 0
|| imm_expr.X_add_number >= 0x10000))
- as_bad (_("lui expression not in range 0..65535"));
+ as_bad (_("lui expression (%lu) not in range 0..65535"),
+ (unsigned long) imm_expr.X_add_number);
s = expr_end;
continue;