This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Sun, 5 Dec 2010 20:38:44 -0500 (EST)
- Subject: Re: [PATCH 08/20] MIPS/GAS: Improve a LUI complaint message
- References: <alpine.DEB.1.10.1012020105230.14129@tp.orcam.me.uk>
On Thu, 2 Dec 2010, Maciej W. Rozycki wrote:
> 2010-12-02 Maciej W. Rozycki <macro@codesourcery.com>
>
> gas/
> * config/tc-mips.c (mips_ip)['u']: Report the value of the LUI
> argument complained about; reword the message.
Just a bikeshed comment from the sideline: The [] in changelog-
entries is canonically for conditionally defined stuff; within
#ifdef X/#if X. For case statements, the canonical marking is
<case X> or <X>, like:
* config/tc-mips.c (mips_ip) <case 'u'>: Report the value of the LUI
or
* config/tc-mips.c (mips_ip) <'u'>: Report the value of the LUI
Feel free to ignore this, I just don't want your format to catch
on - and possibly be forced to use it. ;)
brgds, H-P