Re: PATCH: PR binutils/12283: bfd/doc doesn't support parallel build

[Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>]

Hello H.J.,

* H.J. Lu wrote on Thu, Dec 02, 2010 at 06:00:32PM CET:
> Any objection to this patch?

The rule to update $(MKDOC):

$(MKDOC): $(srcdir)/chew.c
        $(CC_FOR_BUILD) -o chew.$$$$ $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) \
          $(H_CFLAGS) $(AM_CPPFLAGS) $(srcdir)/chew.c; \
        $(SHELL) $(srcdir)/../../move-if-change chew.$$$$ $(MKDOC)

should be atomic (the ';' should be '&&' though).  So, I would be
interested to see the last 100 or so lines of a failure happening,
because I can't spot one nor reproduce it.  Also, configure flags.

Thanks,
Ralf

> 2010-12-02  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR binutils/12283
> 	* doc/Makefile.am: Add proper dependency on $(MKDOC).
> 	* doc/Makefile.in: Regenerated.

> --- a/bfd/doc/Makefile.am
> +++ b/bfd/doc/Makefile.am
> @@ -72,120 +72,93 @@ protos: libbfd.h libcoff.h bfd.h
>  # We can't replace these rules with an implicit rule, because
>  # makes without VPATH support couldn't find the .h files in `..'.
>  
> -# We do not depend on chew directly so that we can distribute the info
> -# files, and permit people to rebuild them, without requiring the makeinfo
> -# program.  If somebody tries to rebuild info, but none of the .texi files
> -# have changed, then nothing will be rebuilt.
> -
> -aoutx.texi: chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
> -	$(MAKE) $(MKDOC)
> +aoutx.texi: $(MKDOC) $(srcdir)/../aoutx.h $(srcdir)/doc.str
>  	./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../aoutx.h >aoutx.tmp
>  	$(SHELL) $(srcdir)/../../move-if-change aoutx.tmp aoutx.texi
[...]