This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH MIPS][LS3A]Generic Support
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> On Thu, 11 Nov 2010 14:47:25 +0100, Maciej W. Rozycki wrote:
>> On Thu, 11 Nov 2010, Nick Clifton wrote:
>>
>> > Approved and applied - thank you very much for creating this patch.
>>
>> Have you addressed any of the concerns I had, especially about changes to
>> include/opcode/mips.h?
>
> Getting now on Fedora 14 x86_64 ./configure --enable-targets=all (...):
>
> make[4]: Entering directory `.../opcodes'
> /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I. -I../bfd -I./../include -I./../bfd -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -m64 -ggdb2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -MT mips-dis.lo -MD -MP -MF .deps/mips-dis.Tpo -c -o mips-dis.lo mips-dis.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I. -I. -I../bfd -I./../include -I./../bfd -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -m64 -ggdb2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -MT mips-dis.lo -MD -MP -MF .deps/mips-dis.Tpo -c mips-dis.c -o mips-dis.o
> cc1: warnings being treated as errors
> In file included from mips-dis.c:27:0:
> ./../include/opcode/mips.h:598:0: error: "INSN_LOONGSON_3A" redefined
> ./../include/opcode/mips.h:596:0: note: this is the location of the previous definition
I've installed the patch below in Nick's absence. (Good luck Nick!)
Richard
include/opcode/
* mips.h: Fix previous commit.
Index: include/opcode/mips.h
===================================================================
--- include/opcode/mips.h 2010-11-23 20:20:46.000000000 +0000
+++ include/opcode/mips.h 2010-11-23 20:20:48.000000000 +0000
@@ -593,9 +593,9 @@ #define INSN_DSPR2 0x2000
/* ST Microelectronics Loongson 2E. */
#define INSN_LOONGSON_2E 0x40000000
/* ST Microelectronics Loongson 2F. */
-#define INSN_LOONGSON_3A 0x00000400
+#define INSN_LOONGSON_2F 0x80000000
/* Loongson 3A. */
-#define INSN_LOONGSON_3A 0x80000400
+#define INSN_LOONGSON_3A 0x00000400
/* RMI Xlr instruction */
#define INSN_XLR 0x00000020