This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold patch] Fix PR gold/12220 where linker script causes internal error with compressed debug sections


On Tue, Nov 16, 2010 at 10:49 AM, Cary Coutant <ccoutant@google.com> wrote:
>> If the code takes this path, it should free the allocated memory after
>> the call to this->namepool_.add_with_length.
>>
>> Also now please remove the handling of is_compressed_debug_section in
>> Layout::output_section_name.
>
> Oops! I meant to remove that.
>
> Here's the patch as committed. (Sorry, I forgot to include ChangeLog
> in the commit, and had to commit it separately.)
>
> -cary
>
> ? ? ? ?PR gold/12220
> ? ? ? ?* layout.cc (Layout::choose_output_section): Transform names of
> ? ? ? ?compressed sections even when using a script with a SECTIONS clause.
> ? ? ? ?(Layout::output_section_name): Remove code to transform
> ? ? ? ?compressed debug section names.
> ? ? ? ?* output.cc (Output_section::add_input_section): Use uncompressed
> ? ? ? ?section size when tracking input sections.
>

I got:

FAIL: debug_msg.sh (exit: 1)
============================

Did not find expected error in debug_msg.err:
   debug_msg.o: in function Base::virtfn():.*/debug_msg.cc:50: error: undefined
reference to 'undef_fn1()'

There may be other problems with compressed debug sections.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]