This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: PATCH: PR gas/12049: Unnecessary relaxation


On Tue, Oct 26, 2010 at 07:06:24PM +0100, Dave Korn wrote:
> On 26/10/2010 18:25, H.J. Lu wrote:
> > On Tue, Oct 26, 2010 at 9:50 AM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
> >>        * i386/relax-1.d: Generalize regexes a bit.
> >>        * i386/relax-2.d: Likewise.

Needs this too.  Some i386 targets interpret .align as .p2align, and
some emit <.somelocallabel-someoffset> instead of <.text>.

	* gas/i386/relax-1.s: Use .p2align, not .align.
	* gas/i386/relax-2.s: Likewise.
	* gas/i386/relax-1.d: Remove label match.
	* gas/i386/relax-2.d: Likewise.  Correct test name.

Index: gas/testsuite/gas/i386/relax-1.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/i386/relax-1.s,v
retrieving revision 1.1
diff -u -p -r1.1 relax-1.s
--- gas/testsuite/gas/i386/relax-1.s	19 Oct 2010 17:13:30 -0000	1.1
+++ gas/testsuite/gas/i386/relax-1.s	26 Oct 2010 21:57:44 -0000
@@ -4,7 +4,7 @@
         .fill 14, 1, 0x90
 	jmp	.LBB1_23
         .fill 18, 1, 0x90
-	.align	16, 0x90
+	.p2align	4, 0x90
         .fill 96, 1, 0x90
 .LBB1_23:
 	nop
Index: gas/testsuite/gas/i386/relax-1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/i386/relax-1.d,v
retrieving revision 1.2
diff -u -p -r1.2 relax-1.d
--- gas/testsuite/gas/i386/relax-1.d	26 Oct 2010 17:36:05 -0000	1.2
+++ gas/testsuite/gas/i386/relax-1.d	26 Oct 2010 21:57:44 -0000
@@ -6,7 +6,6 @@
 
 Disassembly of section .text:
 
-0+ <.text>:
 #...
    e:	e9 8d 00 00 00       	jmp    (0x)?a0( .*)?
 #...
Index: gas/testsuite/gas/i386/relax-2.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/i386/relax-2.s,v
retrieving revision 1.1
diff -u -p -r1.1 relax-2.s
--- gas/testsuite/gas/i386/relax-2.s	19 Oct 2010 17:13:30 -0000	1.1
+++ gas/testsuite/gas/i386/relax-2.s	26 Oct 2010 21:57:44 -0000
@@ -4,7 +4,7 @@
         .fill 10, 1, 0x90
 	jne .LBB0_43
         .fill 5, 1, 0x90
-	.align 16, 0x90
+	.p2align 4, 0x90
         .fill 118, 1, 0x90
 .LBB0_43:
 	nop
Index: gas/testsuite/gas/i386/relax-2.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/i386/relax-2.d,v
retrieving revision 1.2
diff -u -p -r1.2 relax-2.d
--- gas/testsuite/gas/i386/relax-2.d	26 Oct 2010 17:36:05 -0000	1.2
+++ gas/testsuite/gas/i386/relax-2.d	26 Oct 2010 22:08:01 -0000
@@ -1,4 +1,4 @@
-#name: i386 relax 3
+#name: i386 relax 2
 #objdump: -dw
 
 .*: +file format .*
@@ -6,7 +6,6 @@
 
 Disassembly of section .text:
 
-0+ <.text>:
 #...
   38:	0f 85 88 00 00 00    	jne    (0x)?c6( .*)?
 #...

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]